Re: [PATCH v4 00/16] Rewrite x86/ftrace to use text_poke (and more)

From: Ingo Molnar
Date: Mon Oct 21 2019 - 05:09:29 EST

* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> Ftrace was one of the last W^X violators (and KLP it seems). These here patches
> move it over to the generic text_poke() interface and thereby get rid of this
> oddity.
> The first 6 or so patches are more or less the same as in v3, except it has the
> bugs fixed that Steve found:
> - boot time function tracing works
> - module loading with function tracing works
> Then there's 10 new patches, that go all over the place, mostly inspired by
> staring at code touched by the first 6. That is, there's further ftrace and
> kprobes cleanups, as well fixes for various issues.
> In the end, it will have removed the horrible set_all_modules_text_*()
> interface and reduced the ftrace module loading to a single callback (again).
> The ARM patch is compiled only, I would be much obliged if someone could test
> that.

Ok, this looks all around like a nice improvement to me, and fixes a few
bugs as well.

Steve, any objections to this series? If not I'll stick it into
tip:core/kprobes with a tentative v5.5 upstream merge target.