Re: [RFC 1/2] vhost: IFC VF hardware operation layer

[Zhu, Lingshan]

On 10/16/2019 4:45 PM, Jason Wang wrote:
> On 2019/10/16 äå9:30, Zhu Lingshan wrote:
> > + */
> > +#define IFCVF_TRANSPORT_F_START 28
> > +#define IFCVF_TRANSPORT_F_ENDÂÂ 34
> > +
> > +#define IFC_SUPPORTED_FEATURES \
> > +ÂÂÂÂÂÂÂ ((1ULL << VIRTIO_NET_F_MAC)ÂÂÂÂÂÂÂÂÂÂÂ | \
> > +ÂÂÂÂÂÂÂÂ (1ULL << VIRTIO_F_ANY_LAYOUT)ÂÂÂÂÂÂÂÂÂÂÂ | \
> > +ÂÂÂÂÂÂÂÂ (1ULL << VIRTIO_F_VERSION_1) | \
> > +ÂÂÂÂÂÂÂÂ (1ULL << VHOST_F_LOG_ALL)ÂÂÂÂÂÂÂÂÂÂÂ | \
>
>
> Let's avoid using VHOST_F_LOG_ALL, using the get_mdev_features() instead.
Thanks, I will remove VHOST_F_LOG_ALL
> > +ÂÂÂÂÂÂÂÂ (1ULL << VIRTIO_NET_F_GUEST_ANNOUNCE)ÂÂÂÂÂÂÂ | \
> > +ÂÂÂÂÂÂÂÂ (1ULL << VIRTIO_NET_F_CTRL_VQ)ÂÂÂÂÂÂÂÂÂÂÂ | \
> > +ÂÂÂÂÂÂÂÂ (1ULL << VIRTIO_NET_F_STATUS)ÂÂÂÂÂÂÂÂÂÂÂ | \
> > +ÂÂÂÂÂÂÂÂ (1ULL << VIRTIO_NET_F_MRG_RXBUF)) /* not fully supported */
>
>
> Why not having VIRTIO_F_IOMMU_PLATFORM and VIRTIO_F_ORDER_PLATFORM?

I will add VIRTIO_F_ORDER_PLATFORM, for VIRTIO_F_IOMMU_PLATFORM, if we 
add this bit, QEMU may enable viommu, can cause troubles in LM (through 
we don't support LM in this version driver)

Thanks,
BR
Zhu Lingshan
> Thanks