Re: [alsa-devel] [PATCH] ASoC: bdw-rt5677: enable runtime channel merge

From: Pierre-Louis Bossart
Date: Mon Oct 21 2019 - 07:08:11 EST



In the DAI link "Capture PCM", the FE DAI "Capture Pin" supports 4-channel
capture but the BE DAI supports only 2-channel capture. To fix the channel
mismatch, we need to enable the runtime channel merge for this DAI link.


Hi Pierre,

This patch is for the same issue discussed in the following thread:
https://patchwork.kernel.org/patch/11134167/

We enable the runtime channel merge for the DMIC DAI instead of adding a
machine driver constraint. It's working good on chrome's 3.14 branch (which
requires some backport for the runtime channel merge feature). Please let
me know if this implementation is correct for the FE/BE mismatch problem.

Sorry, I don't fully understand your points, and it's the first time I see anyone use this .dpcm_merged_chan field for an Intel platform.

If I look at the code I see that the core would limit the number of channels to two. But that code needs the CPU_DAI to use 2 channels, which I don't see. So is this patch self-contained or do we need an additional constraint on the FE?

Thanks
-Pierre