Re: [PATCH 2/5] mfd: rn5t618: add irq support

From: Andreas Kemnade
Date: Mon Oct 21 2019 - 11:06:55 EST


On Mon, 21 Oct 2019 11:07:10 +0200
Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> wrote:

> Hi,
>
> On 21/10/2019 07:41:01+0200, Andreas Kemnade wrote:
> > +#if 0
> > +/*
> > + * REVISIT when implementing charger:
> > + * according to some other implementation it needs special treatment,
> > + * inverted but experiments seem not to confirm that.
> > + */
> > + [RN5T618_IRQ_CHG] = {
> > + .reg_offset = 0,
> > + .mask = (1 << 6),
> > + }
> > +#endif
>
> Please avoid submitting dead code.
>
ok, I can do some more testing here and add that thing properly.

Regards,
Andreas

Attachment: pgp7FVXqQ191T.pgp
Description: OpenPGP digital signature