Re: [PATCH v2 1/5] perf util: Create new block.h/block.c for block related functions

From: Jiri Olsa
Date: Mon Oct 21 2019 - 12:08:21 EST


On Tue, Oct 15, 2019 at 01:33:46PM +0800, Jin Yao wrote:

SNIP

> diff --git a/tools/perf/util/Build b/tools/perf/util/Build
> index 39814b1806a6..3121c0055950 100644
> --- a/tools/perf/util/Build
> +++ b/tools/perf/util/Build
> @@ -1,4 +1,5 @@
> perf-y += annotate.o
> +perf-y += block.o
> perf-y += block-range.o
> perf-y += build-id.o
> perf-y += cacheline.o
> diff --git a/tools/perf/util/block.c b/tools/perf/util/block.c
> new file mode 100644
> index 000000000000..e5e6f941f040
> --- /dev/null
> +++ b/tools/perf/util/block.c

please use block_info.c, block.c is misleading wrt what
we are doing here..

jirka