Re: [PATCH 2/3] dt: power: Add the bq2515x family dt bindings

[Dan Murphy]

Sebastian

On 10/20/19 7:30 AM, Sebastian Reichel wrote:
> Hi Dan,
>
> On Mon, Sep 30, 2019 at 09:31:36AM -0500, Dan Murphy wrote:
> > Add the bindings for the bq25150 and bq25155 500mA
> >   charging IC from Texas Instruments.
> >
> > Datasheet:
> > http://www.ti.com/lit/ds/symlink/bq25150.pdf
> > http://www.ti.com/lit/ds/symlink/bq25155.pdf
> >
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > ---
> >   .../bindings/power/supply/bq2515x.txt         | 48 +++++++++++++++++++
> This should use the new YAML binding style.


Ack


> >   1 file changed, 48 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/power/supply/bq2515x.txt
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.txt b/Documentation/devicetree/bindings/power/supply/bq2515x.txt
> > new file mode 100644
> > index 000000000000..98203ab53d44
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.txt
> > @@ -0,0 +1,48 @@
> > +Binding for TI bq25150 500-mA Linear charger
> > +
> > +The BQ25150 is a highly integrated battery charge management IC that integrates
> > +the most common functions for wearable devices, namely a charger, an
> > +output voltage rail, ADC for battery and system monitoring, and
> > +push-button controller.
> > +
> > +Required Properties:
> > +	- compatible: Should contain one of the following:
> > +		"ti,bq25150"
> > +		"ti,bq25155"
> > +	- reg: int I2c address 0x6b
> > +	- #address-cells: 1;
> > +	- #size-cells: = 0;
> > +
> > +Optional Properties:
> > +	- ti,battery-regulation-voltage: integer, maximum charging voltage in mV.
> > +		Values range from 3600->4600mV
> > +	- ti,charge-current: integer, maximum charging current in mA.
> > +		Values range from 50->600mA
> Those values should be in uV and uA. Also the values basically
> describe the dumb battery, so please use this binding:
>
> Documentation/devicetree/bindings/power/supply/battery.txt

Ack


> > +	- reset-gpios: GPIO used for Master reset
> > +	- low-power-gpios: GPIO used for low power mode of IC.
> > +	- charge-enable-gpios: GPIO used to turn on and off charging.
> > +	- pg-gpios: GPIO used for connecting the bq2515x device PG (Power Good)
> > +		pin.  This pin should be used if possible as this is the
> > +		recommended way to obtain the charger's input PG state.
> > +		If this pin is not specified a software-based approach for PG
> > +		detection is used.
> > +
> > +Example
> > +bq25150@6b {
> charger@6b

Ack

Dan