Re: [PATCH v2 11/13] drivers: irqchip: qcom-pdc: Add irqchip for sc7180

[Maulik Shah]

On 10/21/2019 1:40 PM, Marc Zyngier wrote:
> On 2019-10-21 07:55, Rajendra Nayak wrote:
> > From: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> >
> > Add sc7180 pdc irqchip
> >
> > Signed-off-by: Maulik Shah <mkshah@xxxxxxxxxxxxxx>
> > Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
> > Cc: Lina Iyer <ilina@xxxxxxxxxxxxxx>
> > Cc: Marc Zyngier <maz@xxxxxxxxxx>
> > ---
> > v2: No change
> >
> > Âdrivers/irqchip/qcom-pdc.c | 1 +
> > Â1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
> > index faa7d61b9d6c..954fb599fa9c 100644
> > --- a/drivers/irqchip/qcom-pdc.c
> > +++ b/drivers/irqchip/qcom-pdc.c
> > @@ -310,3 +310,4 @@ static int qcom_pdc_init(struct device_node
> > *node, struct device_node *parent)
> > Â}
> >
> > ÂIRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
> > +IRQCHIP_DECLARE(pdc_sc7180, "qcom,sc7180-pdc", qcom_pdc_init);
>
> What I gather from these 3 irq-related patches is that as far as
> the PDC is concerned, SDM845/850 and SC7180 are strictly identical.
>
> Why the churn?
>
> ÂÂÂÂÂÂÂ M.

Hi Marc,

Different compatible were used to distinguish since interrupt mapping 
(PDC to GIC) was earlier kept in driver.

Now since mapping is kept in DTSI, we can continue to use 
qcom,sdm845-pdc for sc7180.

i will submit another patch to make it more generic for all SoCs like 
"qcom,pdc".

Thanks,

Maulik

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation