Re: [PATCH 14/18] arm64: efi: restore x18 if it was corrupted

From: Ard Biesheuvel
Date: Tue Oct 22 2019 - 01:54:40 EST

On Tue, 22 Oct 2019 at 00:40, Sami Tolvanen <samitolvanen@xxxxxxxxxx> wrote:
> On Sun, Oct 20, 2019 at 11:20 PM Ard Biesheuvel
> <ard.biesheuvel@xxxxxxxxxx> wrote:
> > You'll have to elaborate a bit here and explain that this is
> > sufficient, given that we run EFI runtime services with interrupts
> > enabled.
> I can add a note about this in v2. This is called with preemption
> disabled and we have a separate interrupt shadow stack, so as far as I
> can tell, this should be sufficient. Did you have concerns about this?

No concerns, but we should put the above clarification in the commit log.