Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS

[Jani Nikula]

On Tue, 22 Oct 2019, Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
> On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote:
>> On Wed, 16 Oct 2019, Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx> wrote:
>> > Fix typo where bits got compared (x < y) instead of shifted (x << y).
>> 
>> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers")
>> Cc: Thierry Reding <treding@xxxxxxxxxx>
>
> I'm not sure we really need the Fixes: tag here. These defines aren't
> used anywhere, so technically there's no bug.

Yeah well, I just logged it here as I happened to do the drive-by git
blame.

BR,
Jani.



>
> Thierry
>
>> 
>> > Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>
>> > ---
>> >  include/drm/drm_scdc_helper.h | 6 +++---
>> >  1 file changed, 3 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h
>> > index f92eb2094d6b..6a483533aae4 100644
>> > --- a/include/drm/drm_scdc_helper.h
>> > +++ b/include/drm/drm_scdc_helper.h
>> > @@ -50,9 +50,9 @@
>> >  #define  SCDC_READ_REQUEST_ENABLE (1 << 0)
>> >  
>> >  #define SCDC_STATUS_FLAGS_0 0x40
>> > -#define  SCDC_CH2_LOCK (1 < 3)
>> > -#define  SCDC_CH1_LOCK (1 < 2)
>> > -#define  SCDC_CH0_LOCK (1 < 1)
>> > +#define  SCDC_CH2_LOCK (1 << 3)
>> > +#define  SCDC_CH1_LOCK (1 << 2)
>> > +#define  SCDC_CH0_LOCK (1 << 1)
>> >  #define  SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK)
>> >  #define  SCDC_CLOCK_DETECT (1 << 0)
>> 
>> -- 
>> Jani Nikula, Intel Open Source Graphics Center
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Graphics Center