Re: [PATCH 3/3 v4] x86/kdump: clean up all the code related to the backup region
From: Borislav Petkov
Date: Tue Oct 22 2019 - 08:15:50 EST
On Thu, Oct 17, 2019 at 05:43:47PM +0800, Lianbo Jiang wrote:
> When the crashkernel kernel command line option is specified, the
> low 1MiB memory will always be reserved, which makes that the memory
> allocated later won't fall into the low 1MiB area, thereby, it's not
> necessary to create a backup region and also no need to copy the first
> 640k content to a backup region.
>
> Currently, the code related to the backup region can be safely removed,
> so lets clean up.
>
> Signed-off-by: Lianbo Jiang <lijiang@xxxxxxxxxx>
> ---
> arch/x86/include/asm/kexec.h | 10 ----
> arch/x86/include/asm/purgatory.h | 10 ----
> arch/x86/kernel/crash.c | 87 ++++--------------------------
> arch/x86/kernel/machine_kexec_64.c | 47 ----------------
> arch/x86/purgatory/purgatory.c | 19 -------
> 5 files changed, 11 insertions(+), 162 deletions(-)
That's a diffstat one cannot object to nowadays. :)
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette