Re: [PATCH 09/22] Input: apanel - switch to using polled mode of input devices

From: Sven Van Asbroeck
Date: Tue Oct 22 2019 - 09:22:13 EST


On Mon, Oct 21, 2019 at 5:27 PM Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
>
> > > +static const struct i2c_device_id apanel_id[] = {
> > > + { "fujitsu_apanel", 0 },
> >
> > If the driver_data field of i2c_device_id is unused, would it
> > be better to match via apanel_driver.driver.of_match_table ?
>
> This is X86 driver, and the device is instantiated from
> drivers/i2c/busses/i2c-i801.c based on DMI match, so using OF is not
> really helpful here.
>

You're right of course! This driver doesn't even select/need CONFIG_OF :)