Re: [PATCH 1/8] ftrace: add ftrace_init_nop()

From: Mark Rutland
Date: Tue Oct 22 2019 - 11:34:02 EST


On Tue, Oct 22, 2019 at 04:30:35PM +0100, Mark Rutland wrote:
> On Tue, Oct 22, 2019 at 08:54:28AM -0400, Steven Rostedt wrote:
> > On Tue, 22 Oct 2019 12:28:11 +0100
> > Mark Rutland <mark.rutland@xxxxxxx> wrote:
> > > | /**
> > > | * ftrace_init_nop - initialize a nop call site
> > > | * @mod: module structure if called by module load initialization
> > > | * @rec: the mcount call site record
> >
> > Perhaps say "mcount/fentry"
>
> This is the exact wording that ftrace_make_nop and ftrace_modify_call
> have. For consistency, I think those should all match.

Now that I read this again, I see what you meant.

If it's ok, I'll change those to:

| @rec: the call site record (e.g. mcount/fentry)

Thanks,
Mark.