Re: [PATCH 13/18] arm64: preserve x18 when CPU is suspended
From: Mark Rutland
Date: Tue Oct 22 2019 - 11:47:43 EST
On Mon, Oct 21, 2019 at 03:43:14PM -0700, Sami Tolvanen wrote:
> On Mon, Oct 21, 2019 at 9:56 AM Mark Rutland <mark.rutland@xxxxxxx> wrote:
> > This should have a corresponding change to cpu_suspend_ctx in
> > <asm/suspend.h>. Otherwise we're corrupting a portion of the stack.
> Ugh, correct. I'll fix this in the next version. Thanks.
It's probably worth extending the comment above cpu_do_suspend to say:
| This must be kept in sync with struct cpu_suspend_ctx in
... to match what we have above struct cpu_suspend_ctx, and make this
more obvious in future.