Re: [PATCH] xen/netback: cleanup init and deinit code

From: Jakub Kicinski
Date: Tue Oct 22 2019 - 14:35:38 EST


On Mon, 21 Oct 2019 07:30:52 +0200, Juergen Gross wrote:
> Do some cleanup of the netback init and deinit code:
>
> - add an omnipotent queue deinit function usable from
> xenvif_disconnect_data() and the error path of xenvif_connect_data()
> - only install the irq handlers after initializing all relevant items
> (especially the kthreads related to the queue)
> - there is no need to use get_task_struct() after creating a kthread
> and using put_task_struct() again after having stopped it.
> - use kthread_run() instead of kthread_create() to spare the call of
> wake_up_process().
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Paul Durrant <pdurrant@xxxxxxxxx>

Applied to net-next, thanks!