Re: [PATCH v2 1/2] dt-bindings: input: Add DT bindings for Whiskers switch

[Dmitry Torokhov]

Hi Ikjoon,

On Mon, Oct 21, 2019 at 11:01:59AM +0800, Ikjoon Jang wrote:
> Add the DT binding document for Hammer's TABLET_MODE switch.
> 
> Signed-off-by: Ikjoon Jang <ikjn@xxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/input/cros-cbas.yaml  | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/cros-cbas.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/cros-cbas.yaml b/Documentation/devicetree/bindings/input/cros-cbas.yaml
> new file mode 100644
> index 000000000000..6a746c4cb266
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/cros-cbas.yaml
> @@ -0,0 +1,25 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/cros-cbas.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ChromeOS Hammer's Base Attached Switch
> +
> +maintainers:
> +  - Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> +
> +description:
> +  On some ChromeOS devices with a foldable variant of Hammer base, SW_TABLET_MODE
> +  event should be generated with proper consideration of current device state.
> +  This device senses "base attached" signal from EC (Embedded Controller)
> +  and generates SW_TABLET_MODE event when Hammer is not attached.

Please change to something like below, because device tree is supposed
to describe hardware, not software behavior.

"This device is used to signal when a detachable base is attached to a
Chrome OS tablet".

> +  The node for this device must be under a cros-ec node like google,cros-ec-spi
> +  or google,cros-ec-i2c.
> +
> +properties:
> +  compatible:
> +   const: google,cros-cbas
> +
> +required:
> +  - compatible

Thanks.

-- 
Dmitry