RE: [EXT] Re: [V5 1/2] dmaengine: fsl-dpaa2-qdma: Add the DPDMAI(Data Path DMA Interface) support

[Peng Ma]

Hi Anders,

The fixed patch link as follows:
https://lore.kernel.org/lkml/20191023021959.35596-1-peng.ma@xxxxxxx/
Please check it.

Best Regards,
Peng
>-----Original Message-----
>From: Anders Roxell <anders.roxell@xxxxxxxxxx>
>Sent: 2019å10æ22æ 19:11
>To: Peng Ma <peng.ma@xxxxxxx>
>Cc: Vinod Koul <vkoul@xxxxxxxxxx>; dan.j.williams@xxxxxxxxx; Leo Li
><leoyang.li@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
>dmaengine@xxxxxxxxxxxxxxx
>Subject: Re: [EXT] Re: [V5 1/2] dmaengine: fsl-dpaa2-qdma: Add the
>DPDMAI(Data Path DMA Interface) support
>
>Caution: EXT Email
>
>On 2019-10-22 10:19, Peng Ma wrote:
>> Hi Anders && Viod,
>>
>> I sent v6 patch to fix the build error, please check.
>
>oh I will check, didn't see them when I sent out my email. =/
>
>Cheers,
>Anders
>
>> Patchwork link:
>> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatc
>>
>hwork.kernel.org%2Fproject%2Flinux-dmaengine%2Flist%2F%3Fseries%3D191
>3
>>
>97&amp;data=02%7C01%7Cpeng.ma%40nxp.com%7C7f201966dd744703dd4
>c08d756e8
>>
>19a2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637073427176
>654617&a
>>
>mp;sdata=%2Fsg0iOhBDCqrTzDxS0WPmQoEmq%2BrvbpZd7xytloH484%3D&a
>mp;reserv
>> ed=0
>>
>> Best Regards,
>> Peng
>> >-----Original Message-----
>> >From: Anders Roxell <anders.roxell@xxxxxxxxxx>
>> >Sent: 2019å10æ22æ 17:27
>> >To: Peng Ma <peng.ma@xxxxxxx>
>> >Cc: Vinod Koul <vkoul@xxxxxxxxxx>; dan.j.williams@xxxxxxxxx; Leo Li
>> ><leoyang.li@xxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
>> >dmaengine@xxxxxxxxxxxxxxx
>> >Subject: Re: [EXT] Re: [V5 1/2] dmaengine: fsl-dpaa2-qdma: Add the
>> >DPDMAI(Data Path DMA Interface) support
>> >
>> >Caution: EXT Email
>> >
>> >On Thu, 17 Oct 2019 at 08:16, Peng Ma <peng.ma@xxxxxxx> wrote:
>> >>
>> >> Hi Vinod,
>> >>
>> >> Thanks very much for your reply.
>> >>
>> >> Best Regards,
>> >> Peng
>> >> >-----Original Message-----
>> >> >From: Vinod Koul <vkoul@xxxxxxxxxx>
>> >> >Sent: 2019å10æ17æ 12:11
>> >> >To: Peng Ma <peng.ma@xxxxxxx>
>> >> >Cc: dan.j.williams@xxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>;
>> >> >linux-kernel@xxxxxxxxxxxxxxx; dmaengine@xxxxxxxxxxxxxxx
>> >> >Subject: [EXT] Re: [V5 1/2] dmaengine: fsl-dpaa2-qdma: Add the
>> >> >DPDMAI(Data Path DMA Interface) support
>> >> >
>> >> >Caution: EXT Email
>> >> >
>> >> >On 30-09-19, 02:04, Peng Ma wrote:
>> >> >> The MC(Management Complex) exports the DPDMAI(Data Path DMA
>> >> >Interface)
>> >> >> object as an interface to operate the DPAA2(Data Path
>> >> >> Acceleration Architecture 2) qDMA Engine. The DPDMAI enables
>> >> >> sending frame-based requests to qDMA and receiving back
>> >> >> confirmation response on transaction completion, utilizing the
>> >> >> DPAA2 QBMan(Queue Manager and Buffer Manager
>> >> >> hardware) infrastructure. DPDMAI object provides up to two
>> >> >> priorities for processing qDMA requests.
>> >> >> The following list summarizes the DPDMAI main features and
>capabilities:
>> >> >>       1. Supports up to two scheduling priorities for processing
>> >> >>       service requests.
>> >> >>       - Each DPDMAI transmit queue is mapped to one of two
>service
>> >> >>       priorities, allowing further prioritization in hardware between
>> >> >>       requests from different DPDMAI objects.
>> >> >>       2. Supports up to two receive queues for incoming transaction
>> >> >>       completion confirmations.
>> >> >>       - Each DPDMAI receive queue is mapped to one of two receive
>> >> >>       priorities, allowing further prioritization between other
>> >> >>       interfaces when associating the DPDMAI receive queues to
>DPIO
>> >> >>       or DPCON(Data Path Concentrator) objects.
>> >> >>       3. Supports different scheduling options for processing
>received
>> >> >>       packets:
>> >> >>       - Queues can be configured either in 'parked' mode (default),
>> >> >>       or attached to a DPIO object, or attached to DPCON object.
>> >> >>       4. Allows interaction with one or more DPIO objects for
>> >> >>       dequeueing/enqueueing frame descriptors(FD) and for
>> >> >>       acquiring/releasing buffers.
>> >> >>       5. Supports enable, disable, and reset operations.
>> >> >>
>> >> >> Add dpdmai to support some platforms with dpaa2 qdma engine.
>> >> >
>> >> >Applied both, thanks
>> >
>> >I see this error when I'm building.
>> >
>> >WARNING: modpost: missing MODULE_LICENSE() in
>> >drivers/dma/fsl-dpaa2-qdma/dpdmai.o
>> >see include/linux/module.h for more information
>> >ERROR: "dpdmai_enable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]
>> >undefined!
>> >ERROR: "dpdmai_set_rx_queue"
>> >[drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
>> >ERROR: "dpdmai_get_tx_queue"
>> >[drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
>> >ERROR: "dpdmai_get_rx_queue"
>> >[drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
>> >ERROR: "dpdmai_get_attributes"
>> >[drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko] undefined!
>> >ERROR: "dpdmai_open" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]
>> >undefined!
>> >ERROR: "dpdmai_close" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]
>> >undefined!
>> >ERROR: "dpdmai_disable" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]
>> >undefined!
>> >ERROR: "dpdmai_reset" [drivers/dma/fsl-dpaa2-qdma/dpaa2-qdma.ko]
>> >undefined!
>> >make[2]: *** [../scripts/Makefile.modpost:95: __modpost] Error 1
>> >make[1]: *** [/srv/src/kernel/next/Makefile:1282: modules] Error 2
>> >make: *** [Makefile:179: sub-make] Error 2
>> >make: Target 'Image' not remade because of errors.
>> >make: Target 'modules' not remade because of errors.
>> >
>> >any other that see the same ?
>> >
>> >Cheers,
>> >Anders