Re: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver

From: Paul Walmsley
Date: Wed Oct 23 2019 - 02:49:25 EST


On Wed, 23 Oct 2019, Anup Patel wrote:

> On Wed, Oct 23, 2019 at 11:30 AM Paul Walmsley <paul.walmsley@xxxxxxxxxx> wrote:
>
> > Is drivers/platform/goldfish/goldfish_pipe.c required for the Goldfish RTC
> > driver or not?
>
> No, it's not required.
>
> > If not, then the first patch that was sent isn't the right fix. It would
> > be better to remove the Kbuild dependency between the code in
> > drivers/platform/goldfish and the Goldfish RTC.
>
> The common GOLDFISH kconfig option is there to specify the
> common expectations of all GOLDFISH drivers from Linux ARCH
> support.

OK, then in that case the Goldfish RTC sounds reasonable to me.


- Paul