Re: [PATCH v2 1/2] habanalabs: support kernel memory mapping
From: Christoph Hellwig
Date: Wed Oct 23 2019 - 05:20:39 EST
On Tue, Oct 22, 2019 at 06:30:35AM +0000, Omer Shpigelman wrote:
> Changes in v2:
> - use a boolean parameter to indicate for kernel address rather than
> calling is_vmalloc_addr, as kernel and user addresses can overlap on
> some architectures.
That is still broken. Please use an actual kernel pointer instead of
losing all type safety by casting it an integer type.