Re: [PATCH 1/1] PCI: Add hp_mmio_size and hp_mmio_pref_size parameters

[Nicholas Johnson]

On Wed, Oct 23, 2019 at 12:47:43PM +0300, mika.westerberg@xxxxxxxxxxxxxxx wrote:
> On Wed, Oct 23, 2019 at 08:37:48AM +0000, Nicholas Johnson wrote:
> >  			} else if (!strncmp(str, "hpmemsize=", 10)) {
> > -				pci_hotplug_mem_size = memparse(str + 10, &str);
> > +				pci_hotplug_mmio_size =
> > +					memparse(str + 10, &str);
> > +				pci_hotplug_mmio_pref_size =
> > +					memparse(str + 10, &str);
> 
> Does this actually work correctly? The first memparse(str + 10, &str)
> modifies str so the next call will not start from the correct position
> anymore.
I have been using this for a long time now and have not had any issues.
Does it modify str? I thought that was done by the loop.

Can somebody else please weigh in here? I am worried now, and I want to 
be sure. If it is a problem, then I will have to read it into 
pci_hotplug_mmio_size and then set:

pci_hotplug_mmio_pref_size = pci_hotplug_mmio_size

> 
> Otherwise the patch looks good to me.
Thanks, I will re-post with your last suggestions of going over 80 
characters shortly.