Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'

[Kalle Valo]

Chris Chiu <chiu@xxxxxxxxxxxx> writes:

> On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>>
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
>>  warning: variable rate_mask set but not used [-Wunused-but-set-variable]
>>
>> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
>> TX performance of RTL8723BU on rtl8xxxu driver")
>>
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>> ---
> Singed-off-by: Chris Chiu <chiu@xxxxxxxxxxxx>

In the future please use Reviewed-by:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

Signed-off-by is supposed to be used when you are sending a patch and
Acked-by is used by the driver maintainer, in this case Jes.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches