Re: [PATCH] rtl8xxxu: remove set but not used variable 'rate_mask'

From: Kalle Valo
Date: Wed Oct 23 2019 - 06:16:56 EST

Chris Chiu <chiu@xxxxxxxxxxxx> writes:

> On Wed, Oct 23, 2019 at 3:54 PM YueHaibing <yuehaibing@xxxxxxxxxx> wrote:
>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:4484:6:
>> warning: variable rate_mask set but not used [-Wunused-but-set-variable]
>> It is never used since commit a9bb0b515778 ("rtl8xxxu: Improve
>> TX performance of RTL8723BU on rtl8xxxu driver")
>> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
>> ---
> Singed-off-by: Chris Chiu <chiu@xxxxxxxxxxxx>

In the future please use Reviewed-by:

Signed-off-by is supposed to be used when you are sending a patch and
Acked-by is used by the driver maintainer, in this case Jes.