Re: [PATCH v14 13/19] leds: lp55xx: Add multicolor framework support to lp55xx

[Dan Murphy]

Jacek

On 10/18/19 5:02 PM, Jacek Anaszewski wrote:
> Dan,
>
> I forgot to mention one thing below.
>
> On 10/18/19 2:25 PM, Dan Murphy wrote:
> > Add multicolor framework support for the lp55xx family.
> >
> > Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
> > ---
> [...]
>
> > -	led->cdev.default_trigger = pdata->led_config[chan].default_trigger;
> >   
> >   	if (led->chan_nr >= max_channel) {
> >   		dev_err(dev, "Use channel numbers between 0 and %d\n",
> > @@ -170,18 +242,13 @@ static int lp55xx_init_led(struct lp55xx_led *led,
> >   		return -EINVAL;
> >   	}
> >   
> > -	led->cdev.brightness_set_blocking = lp55xx_set_brightness;
> > -	led->cdev.groups = lp55xx_led_groups;
> > -
> > -	if (pdata->led_config[chan].name) {
> > -		led->cdev.name = pdata->led_config[chan].name;
> > -	} else {
> > -		snprintf(name, sizeof(name), "%s:channel%d",
> > -			pdata->label ? : chip->cl->name, chan);
> > -		led->cdev.name = name;
> > -	}
> > +#if IS_ENABLED(CONFIG_LEDS_CLASS_MULTI_COLOR)
> > +	if (pdata->led_config[chan].num_colors > 1)
> > +		ret = devm_led_classdev_multicolor_register(dev, &led->mc_cdev);
> > +	else
> > +#endif
> This looks odd. I think that no-ops from previous version were OK.

Hmm. I will add it back but there were issues compiling with modules.

But maybe if I use IS_ENABLED in the header that may solve the issue

Dan