Re: [PATCH v3 5/5] perf report: Sort by sampled cycles percent per block for tui

[Jin, Yao]

On 10/23/2019 7:36 PM, Jiri Olsa wrote:
> On Tue, Oct 22, 2019 at 04:07:10PM +0800, Jin Yao wrote:
> > Previous patch has implemented a new sort option "total_cycles".
> > But there was only stdio mode supported.
> >
> > This patch supports the tui mode and support '--percent-limit'.
> >
> > For example,
> >
> >   perf record -b ./div
> >   perf report -s total_cycles --percent-limit 1
> >
> >   # Samples: 2753248 of event 'cycles'
> >   Sampled Cycles%  Sampled Cycles  Avg Cycles%  Avg Cycles                                              [Program Block Range]         Shared Object
> >            26.04%            2.8M        0.40%          18                                             [div.c:42 -> div.c:39]                   div
> >            15.17%            1.2M        0.16%           7                                 [random_r.c:357 -> random_r.c:380]          libc-2.27.so
> >             5.11%          402.0K        0.04%           2                                             [div.c:27 -> div.c:28]                   div
> >             4.87%          381.6K        0.04%           2                                     [random.c:288 -> random.c:291]          libc-2.27.so
> >             4.53%          381.0K        0.04%           2                                             [div.c:40 -> div.c:40]                   div
> >             3.85%          300.9K        0.02%           1                                             [div.c:22 -> div.c:25]                   div
> >             3.08%          241.1K        0.02%           1                                           [rand.c:26 -> rand.c:27]          libc-2.27.so
> >             3.06%          240.0K        0.02%           1                                     [random.c:291 -> random.c:291]          libc-2.27.so
> >             2.78%          215.7K        0.02%           1                                     [random.c:298 -> random.c:298]          libc-2.27.so
> >             2.52%          198.3K        0.02%           1                                     [random.c:293 -> random.c:293]          libc-2.27.so
> >             2.36%          184.8K        0.02%           1                                           [rand.c:28 -> rand.c:28]          libc-2.27.so
> >             2.33%          180.5K        0.02%           1                                     [random.c:295 -> random.c:295]          libc-2.27.so
> >             2.28%          176.7K        0.02%           1                                     [random.c:295 -> random.c:295]          libc-2.27.so
> >             2.20%          168.8K        0.02%           1                                         [rand@plt+0 -> rand@plt+0]                   div
> >             1.98%          158.2K        0.02%           1                                 [random_r.c:388 -> random_r.c:388]          libc-2.27.so
> >             1.57%          123.3K        0.02%           1                                             [div.c:42 -> div.c:44]                   div
> >             1.44%          116.0K        0.42%          19                                 [random_r.c:357 -> random_r.c:394]          libc-2.27.so
> >
> >   v3:
> >   ---
> >   Minor change since the function name is changed:
> >   block_total_cycles_percent -> block_info__total_cycles_percent
> >
> > Signed-off-by: Jin Yao <yao.jin@xxxxxxxxxxxxxxx>
> > ---
> >   tools/perf/builtin-report.c    | 30 +++++++++++++---
> >   tools/perf/ui/browsers/hists.c | 62 +++++++++++++++++++++++++++++++++-
> >   tools/perf/ui/browsers/hists.h |  2 ++
> >   tools/perf/util/hist.h         | 12 +++++++
> >   4 files changed, 101 insertions(+), 5 deletions(-)
> >
> > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> > index dbae1812ce47..707512f177cb 100644
> > --- a/tools/perf/builtin-report.c
> > +++ b/tools/perf/builtin-report.c
> > @@ -800,6 +800,27 @@ static int hists__fprintf_all_blocks(struct hists *hists, struct report *rep)
> >   	return 0;
> >   }
> >   
> > +static int perf_evlist__tui_block_hists_browse(struct evlist *evlist,
> > +					       struct report *rep)
> > +{
> > +	struct block_hist *bh = &rep->block_hist;
> > +	struct evsel *pos;
> > +	int ret;
> > +
> > +	evlist__for_each_entry(evlist, pos) {
> > +		struct hists *hists = evsel__hists(pos);
> > +
> > +		get_block_hists(hists, bh, rep);
>
> same here, this is display function, compute the data before
>
> thanks,
> jirka

That will be a little bit complicated. But OK, I will try that.

Thanks
Jin Yao

> > +		symbol_conf.report_individual_block = true;
> > +		ret = block_hists_tui_browse(bh, pos, rep->min_percent);
> > +		hists__delete_entries(&bh->block_hists);
> > +		if (ret != 0)
> > +			return ret;
> > +	}
> > +
> > +	return ret;
> > +}
>
> SNIP