[PATCH -next] mtd: rawnand: cadence: Remove dev_err() on platform_get_irq() failure
From: YueHaibing
Date: Wed Oct 23 2019 - 09:57:31 EST
platform_get_irq() will call dev_err() itself on failure,
so there is no need for the driver to also do this.
This is detected by coccinelle.
Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
---
drivers/mtd/nand/raw/cadence-nand-controller.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
index 91dabff..5f07e8e 100644
--- a/drivers/mtd/nand/raw/cadence-nand-controller.c
+++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
@@ -2961,10 +2961,8 @@ static int cadence_nand_dt_probe(struct platform_device *ofdev)
cdns_ctrl->dev = &ofdev->dev;
cdns_ctrl->irq = platform_get_irq(ofdev, 0);
- if (cdns_ctrl->irq < 0) {
- dev_err(&ofdev->dev, "no irq defined\n");
+ if (cdns_ctrl->irq < 0)
return cdns_ctrl->irq;
- }
dev_info(cdns_ctrl->dev, "IRQ: nr %d\n", cdns_ctrl->irq);
cdns_ctrl->reg = devm_platform_ioremap_resource(ofdev, 0);
--
2.7.4