RE: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig

[Ooi, Joyce]

> -----Original Message-----
> From: Dinh Nguyen <dinguyen@xxxxxxxxxx>
> Sent: Monday, October 21, 2019 11:57 PM
> To: Ooi, Joyce <joyce.ooi@xxxxxxxxx>; Vladimir Murzin
> <vladimir.murzin@xxxxxxx>; Catalin Marinas <catalin.marinas@xxxxxxx>; Will
> Deacon <will@xxxxxxxxxx>
> Cc: Shawn Guo <shawnguo@xxxxxxxxxx>; Olof Johansson <olof@xxxxxxxxx>;
> Maxime Ripard <mripard@xxxxxxxxxx>; Bjorn Andersson
> <bjorn.andersson@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Jagan Teki
> <jagan@xxxxxxxxxxxxxxxxxxxx>; Anson Huang <Anson.Huang@xxxxxxx>;
> Leonard Crestez <leonard.crestez@xxxxxxx>; Marcin Juszkiewicz
> <marcin.juszkiewicz@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Ong, Hean Loong <hean.loong.ong@xxxxxxxxx>; See,
> Chin Liang <chin.liang.see@xxxxxxxxx>; Tan, Ley Foon
> <ley.foon.tan@xxxxxxxxx>
> Subject: Re: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig
> 
> 
> 
> On 10/17/19 1:28 AM, Ooi, Joyce wrote:
> > This patch adds JFFS2 FS support and remove QSPI Sector 4K size force
> > in the default defconfig
> >
> > Signed-off-by: Ooi, Joyce <joyce.ooi@xxxxxxxxx>
> > ---
> > v2: disable CONFIG_MTD_SPI_NOR_USE_4K_SECTORS using the correct syntax
> > ---
> >  arch/arm64/configs/defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig index c9adae4..6080c6e 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -860,3 +860,5 @@ CONFIG_DEBUG_KERNEL=y  #
> CONFIG_DEBUG_PREEMPT is
> > not set  # CONFIG_FTRACE is not set  CONFIG_MEMTEST=y
> > +CONFIG_JFFS2_FS=y
> > +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
> >
> 
> Can you explain why you're removing
> CONFIG_MTD_SPI_NOR_USE_4K_SECTORS?
Removing CONFIG_MTD_SPI_NOR_USE_4K_SECTORS will fix errors like this:
[ 1.905772] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x00000f90: 0x00bf instead 
[ 1.915275] jffs2: jffs2_scan_eraseblock(): Magic bitmask 0x1985 not found at 0x00000f94: 0x6abb instead

I'll add this explanation in the commit message.
> 
> Dinh