Re: [PATCH v2] usbip: Fix free of unallocated memory in vhci tx

[shuah]

On 10/22/19 3:51 AM, Julia Lawall wrote:
> On Tue, 22 Oct 2019, Suwan Kim wrote:
>
> > iso_buffer should be set to NULL after use and free in the while loop.
> > In the case of isochronous URB in the while loop, iso_buffer is
> > allocated and after sending it to server, buffer is deallocated. And
> > then, if the next URB in the while loop is not a isochronous pipe,
> > iso_buffer still holds the previously deallocated buffer address and
> > kfree tries to free wrong buffer address.
> >
> > Fixes: ea44d190764b ("usbip: Implement SG support to vhci-hcd and stub driver")
> > Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> > Reported-by: Julia Lawall <julia.lawall@xxxxxxx>
> > Signed-off-by: Suwan Kim <suwan.kim027@xxxxxxxxx>
>
> Reviewed-by: Julia Lawall <julia.lawall@xxxxxxx>
>
> > ---
> > v1 - v2: Move the setting NULL after kfree() and add the comment
> > ---

Thanks.

Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

thanks,
-- Shuah