RE: [PATCH v9 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

From: Leo Li
Date: Wed Oct 23 2019 - 16:07:12 EST




> -----Original Message-----
> From: Ran Wang <ran.wang_1@xxxxxxx>
> Sent: Wednesday, October 23, 2019 4:53 AM
> To: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Cc: Rafael J . Wysocki <rjw@xxxxxxxxxxxxx>; Rob Herring
> <robh+dt@xxxxxxxxxx>; Leo Li <leoyang.li@xxxxxxx>; Mark Rutland
> <mark.rutland@xxxxxxx>; Pavel Machek <pavel@xxxxxx>; Anson Huang
> <anson.huang@xxxxxxx>; Biwen Li <biwen.li@xxxxxxx>; Len Brown
> <len.brown@xxxxxxxxx>; Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx>; linuxppc-dev <linuxppc-
> dev@xxxxxxxxxxxxxxxx>; Linux ARM <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx; Linux Kernel Mailing List <linux-
> kernel@xxxxxxxxxxxxxxx>; Linux PM <linux-pm@xxxxxxxxxxxxxxx>
> Subject: RE: [PATCH v9 1/3] PM: wakeup: Add routine to help fetch wakeup
> source object.
>
> Hi Rafael,
>
> On Wednesday, October 23, 2019 17:07, Rafael J. Wysocki wrote:
> >
> > On Wed, Oct 23, 2019 at 10:24 AM Ran Wang <ran.wang_1@xxxxxxx>
> wrote:
> > >
> > > Some user might want to go through all registered wakeup sources and
> > > doing things accordingly. For example, SoC PM driver might need to
> > > do HW programming to prevent powering down specific IP which wakeup
> > > source depending on. So add this API to help walk through all
> > > registered wakeup source objects on that list and return them one by
> one.
> > >
> > > Signed-off-by: Ran Wang <ran.wang_1@xxxxxxx>
> > > Tested-by: Leonard Crestez <leonard.crestez@xxxxxxx>
> >
> > OK, thanks for making all of the requested changes:
>
> Thanks for your patient direction :)
> Actually Leo and me planed to have a f2f discussion with you about this patch
> on LPC 2019 but unfortunately missed the opportunity finally (v6 review was
> pending at time).
>
> > Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

Thanks for the review.

> >
> > and please feel free to push this through the appropriate arch/platform
> tree.
>
> Yes, we will do this later.
>
> > Alternatively, please let me know if you want me to take this series,
> > but then I need an ACK from the appropriate
> > maintainer(s) on patch 3.
>
> Thanks again, I will wait Leo's comment on patch 3.

I will do another review on patch 3 and apply the series through my soc/fsl tree.

Regards,
Leo