Re: [PATCH] irqchip: Skip contexts other supervisor in plic_init()

From: Marc Zyngier
Date: Thu Oct 24 2019 - 02:51:22 EST


On Wed, 23 Oct 2019 18:30:19 -0700
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Wed, Oct 23, 2019 at 03:07:10PM -0700, Palmer Dabbelt wrote:
> > > > + /* skip contexts other than supervisor external interrupt */
> > > > + if (parent.args[0] != IRQ_S_EXT)
> > > > continue;
> > >
> > > Will this need to change for RISC-V M-mode Linux support?
> > >
> > > https://lore.kernel.org/linux-riscv/20191017173743.5430-1-hch@xxxxxx/
> >
> > Yes.
>
> For M-mode we'll want to check IRQ_M_EXT above. So we should just
> merge this patch ASAP and then for my rebased M-mode series I'll
> fix the check to do that for the M-Mode case, which is much cleaner
> than my hack.

Does this need to be taken as a fix, potentially Cc to stable? Or is
that 5.5 material?

M.
--
Jazz is not dead. It just smells funny...