Re: [BUGFIX PATCH 0/3] perf/probe: Fix available line bugs
From: Arnaldo Carvalho de Melo
Date: Thu Oct 24 2019 - 09:43:32 EST
Em Thu, Oct 24, 2019 at 06:12:27PM +0900, Masami Hiramatsu escreveu:
> Here are some bugfixes related to showing available line (--line/-L)
> option. I found that gcc generated some subprogram DIE with only
> range attribute but no entry_pc or low_pc attributes.
> In that case, perf probe failed to show the available lines in that
> subprogram (function). To fix that, I introduced some bugfixes to
> handle such cases correctly.
Thanks, applied, next time please provide concrete examples for things
that don't work before and gets fixed with your patches, this way we can
more easily reproduce your steps.
> Thank you,
> Masami Hiramatsu (3):
> perf/probe: Fix to find range-only function instance
> perf/probe: Walk function lines in lexical blocks
> perf/probe: Fix to show function entry line as probe-able
> tools/perf/util/dwarf-aux.c | 44 ++++++++++++++++++++++++++++++++++++-------
> tools/perf/util/dwarf-aux.h | 3 +++
> 2 files changed, 40 insertions(+), 7 deletions(-)
> Masami Hiramatsu (Linaro) <mhiramat@xxxxxxxxxx>