Re: [PATCH v1 2/3] drm/tegra: Fix 2d and 3d clients detaching from IOMMU domain
From: Thierry Reding
Date: Thu Oct 24 2019 - 09:50:27 EST
On Thu, Oct 24, 2019 at 04:28:41PM +0300, Dmitry Osipenko wrote:
> 24.10.2019 14:58, Thierry Reding ÐÐÑÐÑ:
> > On Sun, Jun 23, 2019 at 08:37:42PM +0300, Dmitry Osipenko wrote:
> >> This should should fire up on the DRM's driver module re-loader because
> >> there won't be enough available domains on older Tegra SoCs.
> >> Cc: stable <stable@xxxxxxxxxxxxxxx>
> >> Fixes: 0c407de5ed1a ("drm/tegra: Refactor IOMMU attach/detach")
> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> >> ---
> >> drivers/gpu/drm/tegra/dc.c | 4 ++--
> >> drivers/gpu/drm/tegra/drm.c | 9 ++++++---
> >> drivers/gpu/drm/tegra/drm.h | 3 ++-
> >> drivers/gpu/drm/tegra/gr2d.c | 4 ++--
> >> drivers/gpu/drm/tegra/gr3d.c | 4 ++--
> >> 5 files changed, 14 insertions(+), 10 deletions(-)
> > I think I understand what this is trying to do, but the commit message
> > does not help at all. So what's really going on here is that we need to
> > detach the device from the group regardless of whether we're sharing the
> > group or not, just like we attach groups to the shared domain whether
> > they share the same group or not.
> Yes, the commit's message could be improved.
> > But in that case, I wonder if it's even worth splitting groups the way
> > we are right now. Wouldn't it be better to just put all the devices into
> > the same group and be done with it?
> > The current code gives me headaches every time I read it, so if we can
> > just make it so that all the devices under the DRM device share the same
> > group, this would become a lot easier to deal with. I'm not really
> > convinced that it makes much sense to keep them on separate domains,
> > especially given the constraints on the number of domains available on
> > earlier Tegra devices.
> > Note that sharing a group will also make it much easier for these to use
> > the DMA API if it is backed by an IOMMU.
> Probably I'm blanking on everything about IOMMU now.. could you please
> remind me what "IOMMU group" is?
> Isn't it that each IOMMU group relates to the HW ID (SWGROUP)? But then
> each display controller has its own SWGROUP.. and thus that sharing just
> doesn't make any sense, hm.
IOMMU groups are not directly related to SWGROUPs. But by default the
IOMMU framework will share a domain between members of the same IOMMU
group. Seems like that's really what we want here, so that when we do
use the DMA API, all the devices part of the DRM device get attached to
the same IOMMU domain, yet if we don't want to use the DMA API we only
need to detach the one group from the backing.
Description: PGP signature