Re: [PATCH 1/2] asm-generic: Make msi.h a mandatory include/asm header

From: Paul Walmsley
Date: Thu Oct 24 2019 - 11:18:10 EST


On Thu, 24 Oct 2019, Michal Simek wrote:

> msi.h is generic for all architectures expect of x86 which has own version.
> Enabling MSI by including msi.h to architecture Kbuild is just additional
> step which doesn't need to be done.
> The patch was created based on request to enable MSI for Microblaze.
>
> Suggested-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
> ---
>
> https://lore.kernel.org/linux-riscv/20191008154604.GA7903@xxxxxxxxxxxxx/

[ ... ]

> diff --git a/arch/riscv/include/asm/Kbuild b/arch/riscv/include/asm/Kbuild
> index 16970f246860..1efaeddf1e4b 100644
> --- a/arch/riscv/include/asm/Kbuild
> +++ b/arch/riscv/include/asm/Kbuild
> @@ -22,7 +22,6 @@ generic-y += kvm_para.h
> generic-y += local.h
> generic-y += local64.h
> generic-y += mm-arch-hooks.h
> -generic-y += msi.h
> generic-y += percpu.h
> generic-y += preempt.h
> generic-y += sections.h

Acked-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx> # arch/riscv
Tested-by: Paul Walmsley <paul.walmsley@xxxxxxxxxx> # build only, rv32/rv64

Thanks Michał,


- Paul