Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

[Steven Rostedt]

On Thu, 24 Oct 2019 18:43:20 +0200
Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> > 
> >   CC [M]  drivers/gpu/drm/i915/gem/i915_gem_context.o
> > /work/git/linux-trace.git/kernel/trace/trace_events_hist.c: In function âregister_synth_eventâ:
> > /work/git/linux-trace.git/kernel/trace/trace_events_hist.c:1157:15: error: âstruct trace_event_classâ has no member named âdefine_fieldsâ; did you mean âget_fieldsâ?
> >   call->class->define_fields = synth_event_define_fields;
> >                ^~~~~~~~~~~~~
> >                get_fields
> > make[3]: *** [/work/git/linux-trace.git/scripts/Makefile.build:265: kernel/trace/trace_events_hist.o] Error 1
> > make[3]: *** Waiting for unfinished jobs....  
> 
> allmodconfig clean
> 
> (omg, so much __field(); fail)

Well it built without warnings and passed the ftrace selftests.

I haven't ran it through the full suite, but that can wait for the v5.

-- Steve