Re: [PATCH V7] mm/debug: Add tests validating architecture page table helpers

From: Anshuman Khandual
Date: Thu Oct 24 2019 - 23:45:52 EST

On 10/24/2019 10:21 PM, Qian Cai wrote:
>> On Oct 24, 2019, at 10:50 AM, Anshuman Khandual <Anshuman.Khandual@xxxxxxx> wrote:
>> Changes in V7:
>> - Memory allocation and free routines for mapped pages have been droped
>> - Mapped pfns are derived from standard kernel text symbol per Matthew
>> - Moved debug_vm_pgtaable() after page_alloc_init_late() per Michal and Qian
>> - Updated the commit message per Michal
>> - Updated W=1 GCC warning problem on x86 per Qian Cai
> It would be interesting to know if you actually tested out to see if the warning went away. As far I can tell, the GCC is quite stubborn there, so I am not going to insist.

Nothing specific. But just tested this with x86 defconfig with relevant configs
which are required for this test. Not sure if it involved W=1. The problem is,
there is no other or better way to have both the conditional checks in place
while also reducing the chances this warning. IMHO both the conditional checks
are required.