Re: [PATCH 0/2] add regulator driver and mfd cell for Intel Cherry Trail Whiskey Cove PMIC

From: Andy Shevchenko
Date: Fri Oct 25 2019 - 03:53:39 EST


On Thu, Oct 24, 2019 at 02:29:37PM +0000, Andrey Zhizhikin wrote:
> This patchset introduces additional regulator driver for Intel Cherry
> Trail Whiskey Cove PMIC. It also adds a cell in mfd driver for this
> PMIC, which is used to instantiate this regulator.
>
> Regulator support for this PMIC was present in kernel release from Intel
> targeted Aero platform, but was not entirely ported upstream and has
> been omitted in mainline kernel releases. Consecutively, absence of
> regulator caused the SD Card interface not to be provided with Vqcc
> voltage source needed to operate with UHS-I cards.
>
> Following patches are addessing this issue and making sd card interface
> to be fully operable with UHS-I cards. Regulator driver lists an ACPI id
> of the SD Card interface in consumers and exposes optional "vqmmc"
> voltage source, which mmc driver uses to switch signalling voltages
> between 1.8V and 3.3V.
>
> This set contains of 2 patches: one is implementing the regulator driver
> (based on a non upstreamed version from Intel Aero), and another patch
> registers this driver as mfd cell in exising Whiskey Cove PMIC driver.

Thank you.
Hans, Cc'ed, has quite interested in these kind of patches.
Am I right, Hans?

>
>
> Andrey Zhizhikin (2):
> regulator: add support for Intel Cherry Whiskey Cove regulator
> mfd: add regulator cell to Cherry Trail Whiskey Cove PMIC
>
> drivers/mfd/intel_soc_pmic_chtwc.c | 15 +-
> drivers/regulator/Kconfig | 10 +
> drivers/regulator/Makefile | 1 +
> drivers/regulator/intel-cht-wc-regulator.c | 433 ++++++++++++++++++
> .../linux/regulator/intel-cht-wc-regulator.h | 64 +++
> 5 files changed, 521 insertions(+), 2 deletions(-)
> create mode 100644 drivers/regulator/intel-cht-wc-regulator.c
> create mode 100644 include/linux/regulator/intel-cht-wc-regulator.h
>
> --
> 2.17.1
>

--
With Best Regards,
Andy Shevchenko