Re: [PATCH 06/12] microblaze: use pgtable-nopmd instead of 4level-fixup

From: Michal Simek
Date: Fri Oct 25 2019 - 04:24:52 EST


Hi Mike,

On 23. 10. 19 11:28, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@xxxxxxxxxxxxx>
>
> microblaze has only two-level page tables and can use pgtable-nopmd and
> folding of the upper layers.
>
> Replace usage of include/asm-generic/4level-fixup.h and explicit definition
> of __PAGETABLE_PMD_FOLDED in microblaze with
> include/asm-generic/pgtable-nopmd.h and adjust page table manipulation
> macros and functions accordingly.
>
> Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> ---
> arch/microblaze/include/asm/page.h | 3 ---
> arch/microblaze/include/asm/pgalloc.h | 16 ----------------
> arch/microblaze/include/asm/pgtable.h | 32 ++------------------------------
> arch/microblaze/kernel/signal.c | 10 +++++++---
> arch/microblaze/mm/init.c | 7 +++++--
> arch/microblaze/mm/pgtable.c | 13 +++++++++++--
> 6 files changed, 25 insertions(+), 56 deletions(-)

I have take a look at this and when this is applied on the top of
5.4-rc2 there is not a problem.
But as was reported by 0-day there is compilation issue on the top of
mmotm/master tree and I am able to replicate it.
It means there are other changes in Andrew's tree which are causing it.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs