Re: [PATCH v3 08/10] mfd: mfd-core: Protect against NULL call-back function pointer

From: Daniel Thompson
Date: Fri Oct 25 2019 - 04:52:25 EST


On Thu, Oct 24, 2019 at 05:38:30PM +0100, Lee Jones wrote:
> If a child device calls mfd_cell_{en,dis}able() without an appropriate
> call-back being set, we are likely to encounter a panic. Avoid this
> by adding suitable checking.
>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx>

Shouldn't this be earlier in the patch set (to avoid transient
regressions)?


Daniel.