Re: [PATCH 3/7] ASoC: amd: Enabling I2S instance in DMA and DAI

[vishnu]

On 25/10/19 3:25 PM, Mark Brown wrote:
> On Fri, Oct 25, 2019 at 06:53:16AM +0000, vishnu wrote:
>> On 24/10/19 5:10 PM, Mark Brown wrote:
>>> On Sat, Oct 19, 2019 at 02:35:41AM +0530, Ravulapati Vishnu vardhan rao wrote:
> 
>>>> +		case I2S_BT_INSTANCE:
>>>> +			val = rv_readl(rtd->acp3x_base + mmACP_BTTDM_ITER);
>>>> +			val = val | (rtd->xfer_resolution  << 3);
>>>> +			rv_writel(val, rtd->acp3x_base + mmACP_BTTDM_ITER);
>>>> +		break;
> 
>>> For some reason the break; isn't indented with the rest of the block.
>>> I'm fairly sure I've mentioned this before...
> 
>> Sorry for this but I am not able to find indentation.I have tested with
>> scripts/checkpatch.pl. It shows no warnings.
> 
> The break should be aligned with the rest of the block like I said, an
> extra tab in - you can see lots of examples of break statements in the
> kernel.
> 
Yes Got it.Thanks for your comments.I will create a separate patch for 
fixing this issue.

Regards,
Vishnu