Re: [PATCH 1/2] regulator: add support for Intel Cherry Whiskey Cove regulator

[Andy Shevchenko]

On Fri, Oct 25, 2019 at 11:31:50AM +0200, Andrey Zhizhikin wrote:
> On Fri, Oct 25, 2019 at 11:14 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > On Fri, Oct 25, 2019 at 10:58:05AM +0200, Andrey Zhizhikin wrote:
> > > On Fri, Oct 25, 2019 at 10:01 AM Andy Shevchenko
> > > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > > > On Thu, Oct 24, 2019 at 02:29:38PM +0000, Andrey Zhizhikin wrote:
> > > > > Add regulator driver for Intel Cherry Trail Whiskey Cove PMIC, which
> > > > > supplies various voltage rails.
> > > > >
> > > > > This initial version supports only vsdio, which is required to source
> > > > > vqmmc for sd card interface.
> > > >
> > > > This patch has some style issues. I will wait for Adrian and Hans to comment on
> > > > the approach as a whole and then we will see how to improve the rest.
> > >
> > > Agreed, styling issues are coming from definition of CHT_WC_REGULATOR
> > > elements in regulators_info array, and they are mainly related to 80
> > > characters per line. I decided to leave it like this since it is more
> > > readable. But if the 80 characters rule is to be enforced here - I can
> > > go with something like this for every element:
> > > CHT_WC_REGULATOR(V3P3A,    3000, 3350, 0x00, 0x07,\
> > >                                      50, 0x01, 0x01, 0x0, true,  NULL),
> >
> > No, I'm not talking about these. Actually I hate this 80 limit in 21st century.
> > But let's not discuss it right now.
> 
> I just ran a checkpatch and I think I know what you're referring to:
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> 
> In this case I really have to wait what others have to say, since I do
> not know who and how the maintainer would be assigned.

Neither this :-) Whoever it's an interesting warning from checkpatch.

-- 
With Best Regards,
Andy Shevchenko