Re: [EXT] [PATCH net-next] net: aquantia: Fix build error wihtout CONFIG_PTP_1588_CLOCK
From: Igor Russkikh
Date: Fri Oct 25 2019 - 11:06:37 EST
> If PTP_1588_CLOCK is n, building fails:
> drivers/net/ethernet/aquantia/atlantic/aq_ptp.c: In function aq_ptp_adjfine:
> error: implicit declaration of function scaled_ppm_to_ppb [-Werror=implicit-function-declaration]
Thanks for noticing this. It seems I've added scaled_ppm_to_ppb usage but did
not checked PTP_1588_CLOCK=n case after that.
> Just cp scaled_ppm_to_ppb() from ptp_clock.c to fix this.
I'm honestly not sure if duplicating the code is a good way here.
I'll think on how to exclude at_ptp at all on such a config.