Re: [PATCH v9 1/8] powerpc: detect the secure boot mode of the system

From: Nayna Jain
Date: Fri Oct 25 2019 - 12:50:51 EST

On 10/24/19 12:26 PM, Lakshmi Ramasubramanian wrote:
On 10/23/2019 8:47 PM, Nayna Jain wrote:
This patch defines a function to detect the secure boot state of a
PowerNV system.

+bool is_ppc_secureboot_enabled(void)
+ÂÂÂ struct device_node *node;
+ÂÂÂ bool enabled = false;
+ÂÂÂ node = of_find_compatible_node(NULL, NULL, "ibm,secvar-v1");
+ÂÂÂ if (!of_device_is_available(node)) {
+ÂÂÂÂÂÂÂ pr_err("Cannot find secure variable node in device tree; failing to secure state\n");
+ÂÂÂÂÂÂÂ goto out;

Related to "goto out;" above:

Would of_find_compatible_node return NULL if the given node is not found?

If of_device_is_available returns false (say, because node is NULL or it does not find the specified node) would it be correct to call of_node_put?

of_node_put() handles NULL.

Thanks & Regards,

ÂÂÂÂ - Nayna