Re: [PATCH] mfd: db8500-prcmu: Support U8420-sysclk firmware

From: Linus Walleij
Date: Sat Oct 26 2019 - 16:10:47 EST


On Sat, Oct 26, 2019 at 4:37 PM Stephan Gerhold <stephan@xxxxxxxxxxx> wrote:

> > irqchip_init();
> > + prcmu_early_init();
> > np = of_find_compatible_node(NULL, NULL, "stericsson,db8500-prcmu");
>
> Maybe it would make sense to give the struct device_node *np pointer as
> parameter to prcmu_early_init() to avoid duplicating the lookup of the
> device tree node there? But not sure if this is worth it.

I wanted to make the PRCMU driver more stand-alone, looking up
its own resources etc, so I prefer to keep it like this. The other
use in mach-ux500/cpu-db8500.c is the power domains that
should ideally also become a separate driver.

This is called very early on init_IRQ() -> machine->init_irq()
and I just don't know any better way to sneak in before
init_time(), else I would use it...

Fixed the rest!

Thanks a lot,
Linus Walleij