Re: [PATCH v2 05/17] add support for Clang's Shadow Call Stack (SCS)

From: Sami Tolvanen
Date: Mon Oct 28 2019 - 11:20:05 EST


Hi Joe,

On Sat, Oct 26, 2019 at 8:57 AM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > +#if __has_feature(shadow_call_stack)
> > +# define __noscs __attribute__((no_sanitize("shadow-call-stack")))
>
> __no_sanitize__

Sorry, I missed your earlier message about this. I'm following Clang's
documentation for the attribute:

https://clang.llvm.org/docs/ShadowCallStack.html#attribute-no-sanitize-shadow-call-stack

Although __no_sanitize__ seems to work too. Is there a particular
reason to prefer that form over the one in the documentation?

Sami