Re: [PATCH] compiler*.h: Add '__' prefix and suffix to all __attribute__ #defines
From: Luc Van Oostenryck
Date: Mon Oct 28 2019 - 18:15:30 EST
On Mon, Oct 28, 2019 at 10:59:47AM -0700, Joe Perches wrote:
> On Mon, 2019-10-28 at 18:37 +0100, Miguel Ojeda wrote:
> > Just in case: for these ones (i.e. __CHECKER__), did you check if
> > sparse handles this syntax? (I don't recall myself if it does).
> > Other than that, thanks for the cleanup too! I can pick it up in the
> > the compiler-attributes tree and put it in -next.
> Thanks for asking and no, I did not until just now.
> Turns out sparse does _not_ handle these changes and
> the checking fails for these __<changes>__.
> sparse would have to update parse.c or the __CHECKER__
> changes would need to be reverted.
> Perhaps update parse.c like:
Yes, this was missing. Thanks.
Can I have your SoB for this?