Re: [RFC PATCH v2 02/13] dt-bindings: mfd: Document ROHM BD71828 bindings

From: Lee Jones
Date: Tue Oct 29 2019 - 08:08:28 EST


On Fri, 25 Oct 2019, Vaittinen, Matti wrote:

> Hello Dan,
>
> Thanks again for checking this :)
>
> On Thu, 2019-10-24 at 14:35 -0500, Dan Murphy wrote:
> > Matti
> >
> > On 10/24/19 6:41 AM, Matti Vaittinen wrote:
> > > ROHM BD71828 Power management IC integrates 7 buck converters, 7
> > > LDOs,
> > > a real-time clock (RTC), 3 GPO/regulator control pins, HALL input
> > > and a 32.768 kHz clock gate.
> > >
> > > Document the dt bindings drivers are using.
> > >
> > > Signed-off-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> > > ---
> > >
> > > No changes since v1
> > >
> > > .../bindings/mfd/rohm,bd71828-pmic.txt | 180
> > > ++++++++++++++++++
> > > 1 file changed, 180 insertions(+)
> > > create mode 100644
> > > Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.txt
> >
> > I will let maintainers weigh in here but if this is new this should
> > probably be in the yaml format to avoid conversion in the future

Yes please.

> Oh... This is new to me. I guess there are reasons for this - but I
> must say I am not excited as I have never used yaml for anything. I'll
> do as you suggest and wait for what others have to say :) Thanks for
> pointing this out though.

--
Lee Jones [æçæ]
Linaro Services Technical Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog