Re: [PATCH v4 5/7] perf report: Sort by sampled cycles percent per block for stdio

[Jin, Yao]

On 10/29/2019 5:27 PM, Jiri Olsa wrote:
> On Mon, Oct 28, 2019 at 09:33:28AM +0800, Jin Yao wrote:
>
> SNIP
>
> > diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> > index 0e27d6830011..7cf137b0451b 100644
> > --- a/tools/perf/util/hist.c
> > +++ b/tools/perf/util/hist.c
> > @@ -758,6 +758,10 @@ struct hist_entry *hists__add_entry_block(struct hists *hists,
> >   	struct hist_entry entry = {
> >   		.block_info = block_info,
> >   		.hists = hists,
> > +		.ms = {
> > +			.map = al->map,
> > +			.sym = al->sym,
> > +		},
>
> this looks like separated fix, if thats the case
> please explain the change and move it to separate patch
>
> thanks,
> jirka

Sorry, that should be the obsolete code. Thanks so much for pointing 
this out.

Thanks
Jin Yao