Re: [PATCH] pstore: make 'pstore_choose_compression' static

From: Kees Cook
Date: Tue Oct 29 2019 - 12:41:15 EST


On Wed, Oct 16, 2019 at 01:33:17PM +0100, Ben Dooks (Codethink) wrote:
> The pstore_choose_compression function is not exported
> so make it static to avoid the following sparse warning:
>
> fs/pstore/platform.c:796:13: warning: symbol 'pstore_choose_compression' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>

Oops! Yes, thank you. Applied to my for-next/pstore branch. :)

-Kees

> ---
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Anton Vorontsov <anton@xxxxxxxxxx>
> Cc: Colin Cross <ccross@xxxxxxxxxxx>
> Cc: Tony Luck <tony.luck@xxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> ---
> fs/pstore/platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
> index 3d7024662d29..d896457e7c11 100644
> --- a/fs/pstore/platform.c
> +++ b/fs/pstore/platform.c
> @@ -793,7 +793,7 @@ static void pstore_timefunc(struct timer_list *unused)
> jiffies + msecs_to_jiffies(pstore_update_ms));
> }
>
> -void __init pstore_choose_compression(void)
> +static void __init pstore_choose_compression(void)
> {
> const struct pstore_zbackend *step;
>
> --
> 2.23.0
>

--
Kees Cook