Re: [PATCH 2/4] thermal: stm32: fix IRQ flood on low threshold

From: Joe Perches
Date: Tue Oct 29 2019 - 13:15:49 EST


On Tue, 2019-10-29 at 18:11 +0100, Daniel Lezcano wrote:
> On 29/10/2019 17:45, Pascal Paillet wrote:
> > Fix IRQ flood on low threshold by too ways:
>
> Can you state the issue first ?
>
> > - improve temperature reading resolution,
> > - add an hysteresis to the low threshold: on low threshold interrupt,
> > it is not possible to get the temperature value that has fired the
> > interrupt. The time to acquire a new value is enough for the CPU to
> > become hotter than the current low threshold.
[]
> > Signed-off-by: Pascal Paillet <p.paillet@xxxxxx>
> > Change-Id: I3b63b8aab38fd651a165c4e69a2d090b3c6f5db3
>
> Please remove the Change-Id tag.
>
> Joe, Andy? checkpatch does not see the Change-Id, is it the expected
> behavior?

Yes. It's after a sign-off so checkpatch doesn't care.