Re: [PATCH 1/2] dt-bindings: arm: at91: Document Kizbox2 boards binding

[Kamel Bouhara]

On 29/10/2019 02:49, Rob Herring wrote:
> On Thu, Oct 17, 2019 at 10:54:04AM +0200, Kamel Bouhara wrote:
> > Document devicetree's bindings for the SAMA5D31 Kizbox2 boards of
> > Overkiz SAS.
> >
> > Signed-off-by: Kamel Bouhara <kamel.bouhara@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/arm/atmel-at91.yaml   | 35 +++++++++++++++++++
> >   1 file changed, 35 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > index c0869cb860f3..7636bf7c2382 100644
> > --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> > @@ -80,6 +80,41 @@ properties:
> >             - const: atmel,sama5d3
> >             - const: atmel,sama5
> >   
> > +      - description: Overkiz kizbox2 board without antenna
> > +        items:
> > +          - const: overkiz,kizbox2-0
> > +          - const: atmel,sama5d31
> > +          - const: atmel,sama5d3
> > +          - const: atmel,sama5
> > +
> > +      - description: Overkiz kizbox2 board with one head
> > +        items:
> > +          - const: overkiz,kizbox2-1
> > +          - const: atmel,sama5d31
> > +          - const: atmel,sama5d3
> > +          - const: atmel,sama5
> > +
> > +      - description: Overkiz kizbox2 board with two heads
> > +        items:
> > +          - const: overkiz,kizbox2-2
> > +          - const: atmel,sama5d31
> > +          - const: atmel,sama5d3
> > +          - const: atmel,sama5
> > +
> > +      - description: Overkiz kizbox2 board with three heads
> > +        items:
> > +          - const: overkiz,kizbox2-3
> > +          - const: atmel,sama5d31
> > +          - const: atmel,sama5d3
> > +          - const: atmel,sama5
> > +
> > +      - description: Overkiz kizbox2 board Rev2 with two heads
> > +        items:
> > +          - const: overkiz,kizbox2-rev2
> > +          - const: atmel,sama5d31
> > +          - const: atmel,sama5d3
> > +          - const: atmel,sama5
>
> These can all be made a single items list with the 1st entry being an
> enum of all the boards. The board description can be a comment.
>
> Rob
Yes agree, actually it's already done in v2, by the way thanks for the 
review.

--
Kamel Bouhara, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com