Re: [PATCH 0/3] net: phy: initialize PHYs via device tree properties

[Michael Walle]

Am 2019-10-29 21:59, schrieb Florian Fainelli:
> > > If all you need is to enable a particular clock, introduce device
> > > specific properties that describe the hardware, and make the 
> > > necessary
> > > change to the local driver that needs to act on those. You can always
> > > define a more generic scope property if you see a recurring pattern.
> >
> > Could you have a quick look at the following patch I made for u-boot, 
> > which adds a binding for the Atheros PHY. If that is the right 
> > direction. Yeah, I should have made it first to Linux to get some 
> > feedback on the binding :p
> >
> > https://patchwork.ozlabs.org/patch/1184516/
> >
> > I'd then prepare another patch for Linux based on your suggestions.
>
> This looks like the right direction IMHO.

Ok, one question though: There is a clock output, but it just supports 
four frequencies. Should there be a property like 
"atheros,clk-out-frequency = <25000000>" which can take an arbitrary 
number or should it be something like "atheros,clk-out-frequency = 
<AT803X_CLK_OUT_25_MHZ>" (the ti dp83867 uses the latter).

-michael