Re: [PATCH] tty: n_hdlc: fix build on SPARC

[Kees Cook]

On Wed, Oct 30, 2019 at 08:29:40PM +0100, John Paul Adrian Glaubitz wrote:
> On 10/30/19 7:34 PM, Kees Cook wrote:
> > On Mon, Sep 30, 2019 at 07:15:12PM -0700, Randy Dunlap wrote:
> >> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> >>
> >> Fix tty driver build on SPARC by not using __exitdata.
> >> It appears that SPARC does not support section .exit.data.
> >>
> >> Fixes these build errors:
> >>
> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> >> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> >>
> >> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> >> Fixes: 063246641d4a ("format-security: move static strings to const")
> >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > 
> > Wow. That commit is from 2.5 years ago. Is the SPARC port still alive?
> Yes, it is. No idea why we didn't run into this. I assume it affects certain
> configurations only. On Debian, we are always compiling and running the
> latest kernel versions on sparc64.

Yeah, that's what I thought. I also didn't hit it 2.5 years ago when I
did multi-architecture build validation of these changes. :P

Randy you've found a nice corner case! :)

-- 
Kees Cook