Re: [PATCH] mm/ioremap: Use WARN_ONCE instead of printk() + WARN_ON_ONCE()

[zhong jiang]

On 2019/10/31 19:03, Borislav Petkov wrote:
> On Wed, Oct 30, 2019 at 04:57:18PM +0800, zhong jiang wrote:
>> WARN_ONCE is more clear and simpler. Just replace it.
>>
>> Signed-off-by: zhong jiang <zhongjiang@xxxxxxxxxx>
>> ---
>>  arch/x86/mm/ioremap.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
>> index a39dcdb..3b74599 100644
>> --- a/arch/x86/mm/ioremap.c
>> +++ b/arch/x86/mm/ioremap.c
>> @@ -172,9 +172,8 @@ static void __ioremap_check_mem(resource_size_t addr, unsigned long size,
>>  		return NULL;
>>  
>>  	if (!phys_addr_valid(phys_addr)) {
>> -		printk(KERN_WARNING "ioremap: invalid physical address %llx\n",
>> -		       (unsigned long long)phys_addr);
>> -		WARN_ON_ONCE(1);
>> +		WARN_ONCE(1, "ioremap: invalid physical address %llx\n",
>> +			  (unsigned long long)phys_addr);
> Does
> 	WARN_ONCE(!phys_addr_valid(phys_addr),
> 		  "ioremap: invalid physical address %llx\n",
> 		  (unsigned long long)phys_addr);
>
> work too?
>
Thanks, That is better. Will repost.